From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113AbbBMTuW (ORCPT ); Fri, 13 Feb 2015 14:50:22 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:45228 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbbBMTuU (ORCPT ); Fri, 13 Feb 2015 14:50:20 -0500 Date: Fri, 13 Feb 2015 19:50:18 +0000 (GMT) From: "Maciej W. Rozycki" To: Andreas Ruprecht cc: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Valentin Rothberg , Paul Bolle Subject: Re: [PATCH] MIPS: mm: Remove dead macro definitions In-Reply-To: <1423748572-31012-1-git-send-email-rupran@einserver.de> Message-ID: References: <1423748572-31012-1-git-send-email-rupran@einserver.de> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Feb 2015, Andreas Ruprecht wrote: > In commit c441d4a54c6e ("MIPS: mm: Only build one microassembler that > is suitable"), the Makefile at arch/mips/mm was rewritten to only > build the "right" microassembler file, depending on whether > CONFIG_CPU_MICROMIPS is set or not. > > In the files, however, there are still preprocessor definitions > depending on CONFIG_CPU_MICROMIPS. The #ifdef around them can now > never evaluate to true, so let's remove them altogether. > > This inconsistency was found using the undertaker-checkpatch tool. > > Signed-off-by: Andreas Ruprecht > --- Reviewed-by: Maciej W. Rozycki Thanks for catching it! Maciej