From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756213AbbCFLKA (ORCPT ); Fri, 6 Mar 2015 06:10:00 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:60097 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbbCFLIU (ORCPT ); Fri, 6 Mar 2015 06:08:20 -0500 Date: Fri, 6 Mar 2015 11:08:16 +0000 (GMT) From: "Maciej W. Rozycki" To: Andrew Bresticker cc: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Provide fallback reboot/poweroff/halt implementations In-Reply-To: <1425513563-9897-1-git-send-email-abrestic@chromium.org> Message-ID: References: <1425513563-9897-1-git-send-email-abrestic@chromium.org> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Mar 2015, Andrew Bresticker wrote: > If a machine-specific hook is not implemented for restart, poweroff, > or halt, fall back to halting secondary CPUs, disabling interrupts, > and spinning. In the case of restart, attempt to restart the system > via do_kernel_restart() (which will call any registered restart > handlers) before halting. > > Signed-off-by: Andrew Bresticker > --- > arch/mips/kernel/reset.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c > index 07fc524..87b1f08 100644 > --- a/arch/mips/kernel/reset.c > +++ b/arch/mips/kernel/reset.c > @@ -29,16 +29,36 @@ void machine_restart(char *command) > { > if (_machine_restart) > _machine_restart(command); > + > +#ifdef CONFIG_SMP > + smp_send_stop(); > +#endif > + do_kernel_restart(command); > + pr_emerg("Reboot failed -- System halted\n"); > + local_irq_disable(); > + while (1); I think it would make sense to put WAIT or suchlike in the final loop so that such a halted system does not suck power unnecessarily. I think bits in arch/mips/kernel/idle.c should do, after some massaging. As the next step perhaps, don't treat it as a NACK for this change. Maciej