From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753840AbbCFM3X (ORCPT ); Fri, 6 Mar 2015 07:29:23 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:32855 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbbCFM3V (ORCPT ); Fri, 6 Mar 2015 07:29:21 -0500 Date: Fri, 6 Mar 2015 11:58:31 +0000 (GMT) From: "Maciej W. Rozycki" To: Deng-Cheng Zhu , Russell King cc: linux-mips@linux-mips.org, Ralf Baechle , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/15] MIPS: Add sched_clock support In-Reply-To: <1425517137-26463-5-git-send-email-dengcheng.zhu@imgtec.com> Message-ID: References: <1425517137-26463-1-git-send-email-dengcheng.zhu@imgtec.com> <1425517137-26463-5-git-send-email-dengcheng.zhu@imgtec.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Mar 2015, Deng-Cheng Zhu wrote: > This will provide sched_clock interface to implement individual > read_sched_clock(). Not for CAVIUM_OCTEON_SOC as it defines its own > sched_clock() directly (not using the sched_clock_register interface). > > Signed-off-by: Deng-Cheng Zhu > --- > arch/mips/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 068592a..09405dc 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -43,6 +43,7 @@ config MIPS > select GENERIC_SMP_IDLE_THREAD > select BUILDTIME_EXTABLE_SORT > select GENERIC_CLOCKEVENTS > + select GENERIC_SCHED_CLOCK if !CAVIUM_OCTEON_SOC > select GENERIC_CMOS_UPDATE > select HAVE_MOD_ARCH_SPECIFIC > select VIRT_TO_BUS Why does this change add this question: ARM Versatile (Express) reference platforms clock source (CLKSRC_VERSATILE) [N/y/?] (NEW) ? This option enables clock source based on free running counter available in the "System Registers" block of ARM Versatile, RealView and Versatile Express reference platforms. Symbol: CLKSRC_VERSATILE [=n] Type : boolean Prompt: ARM Versatile (Express) reference platforms clock source Location: -> Device Drivers -> Clock Source drivers Defined at drivers/clocksource/Kconfig:216 Depends on: GENERIC_SCHED_CLOCK [=y] && !ARCH_USES_GETTIMEOFFSET [=n] Selects: CLKSRC_OF [=n] to a MIPS configuration? I find it silly, this appears a platform device to me (use reverse dependencies?). Maciej