From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753122AbcDFSz5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Apr 2016 14:55:57 -0400
Received: from casper.infradead.org ([85.118.1.10]:43012 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752860AbcDFSz4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Apr 2016 14:55:56 -0400
Date: Wed, 6 Apr 2016 19:55:52 +0100 (BST)
From: James Simmons <jsimmons@infradead.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
cc: Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        lustre-devel@lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging/lustre/obdclass: fix build
 warning
In-Reply-To: <1459867534-4507-1-git-send-email-sudipm.mukherjee@gmail.com>
Message-ID: <alpine.LFD.2.20.1604061955160.18149@casper.infradead.org>
References: <1459867534-4507-1-git-send-email-sudipm.mukherjee@gmail.com>
User-Agent: Alpine 2.20 (LFD 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20160406_195552_236231_B504678F 
X-CRM114-Status: UNSURE (   9.92  )
X-CRM114-Notice: Please train this message.
X-Spam-Score: -1.9 (-)
X-Spam-Report: SpamAssassin version 3.4.0 on casper.infradead.org summary:
 Content analysis details:   (-1.9 points, 5.0 required)
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 NO_RELAYS              Informational: message was not relayed via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> While building with W=1 we were getting the warning:
> 
> drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16:
> 	warning: old-style function definition
>  struct lu_env *cl_env_percpu_get()
>                 ^
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Acked-by: James Simmons <jsimmons@infradead.org>

> ---
>  drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> index 395b92c..d84ec00 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> @@ -1053,7 +1053,7 @@ void cl_env_percpu_put(struct lu_env *env)
>  }
>  EXPORT_SYMBOL(cl_env_percpu_put);
>  
> -struct lu_env *cl_env_percpu_get()
> +struct lu_env *cl_env_percpu_get(void)
>  {
>  	struct cl_env *cle;
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>