From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbcEDNtP (ORCPT ); Wed, 4 May 2016 09:49:15 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33122 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbcEDNtO (ORCPT ); Wed, 4 May 2016 09:49:14 -0400 Date: Wed, 4 May 2016 15:49:06 +0200 (CEST) From: John Kacur X-X-Sender: jkacur@riemann To: Luiz Capitulino cc: Clark Williams , RT , LKML Subject: Re: [PATCH] cyclictest: stop any tracing after hitting a breaktrace threshold In-Reply-To: <20160504092051.54002514@redhat.com> Message-ID: References: <20160503125953.1987bedd@sluggy.hsv.redhat.com> <20160503155644.0aa34c34@redhat.com> <20160503152839.4543a973@sluggy.hsv.redhat.com> <20160504092051.54002514@redhat.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 May 2016, Luiz Capitulino wrote: > On Tue, 3 May 2016 15:28:39 -0500 > Clark Williams wrote: > > > The intent is to be able to do something like this: > > > > trace-cmd start -e all -p function > > rteval --duration=12h --cyclictest-breaktrace=150 > > trace-cmd extract > > Ah, ok, I get it now. This makes sense. > > I think I'd refactor the code opening tracing_on to its own > function so that we avoid the duplicate code in setup_tracer(), > but in any case: > > Reviewed-by: Luiz Capitulino > -- Sorry, resending with a sane mailer I don't see a better solution for now, so adding Luiz Reviewed by Signed-off-by: John Kacur and pushed to devel