From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932321AbcHOVI5 (ORCPT ); Mon, 15 Aug 2016 17:08:57 -0400 Received: from casper.infradead.org ([85.118.1.10]:45574 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115AbcHOVI4 (ORCPT ); Mon, 15 Aug 2016 17:08:56 -0400 Date: Mon, 15 Aug 2016 22:08:51 +0100 (BST) From: James Simmons To: Greg Kroah-Hartman cc: Joe Perches , Oleg Drokin , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to Makefile In-Reply-To: <20160815210420.GA30864@kroah.com> Message-ID: References: <5f9f49c1e0caeb3b9ee0656b6d922dbaf52a15b7.1471289489.git.joe@perches.com> <20160815210420.GA30864@kroah.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160815_220851_524920_EC5C1A72 X-CRM114-Status: GOOD ( 12.92 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote: > > Start to rationalize include paths in source code files. > > > > Signed-off-by: Joe Perches > > --- > > drivers/staging/lustre/Makefile | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile > > index 95ffe33..9d00237 100644 > > --- a/drivers/staging/lustre/Makefile > > +++ b/drivers/staging/lustre/Makefile > > @@ -1,2 +1,5 @@ > > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/ > > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/ > > + > > obj-$(CONFIG_LNET) += lnet/ > > obj-$(CONFIG_LUSTRE_FS) += lustre/ > > This is good, but does this break the subdir make command: > make M=drivers/staging/lustre/foo_dir/ > ? > > I remember the last time I tried to clean this up, it took a while... It breaks make M=drivers/staging/lustre/foo_dir