From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692AbcIHRvw (ORCPT ); Thu, 8 Sep 2016 13:51:52 -0400 Received: from casper.infradead.org ([85.118.1.10]:50388 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbcIHRvv (ORCPT ); Thu, 8 Sep 2016 13:51:51 -0400 Date: Thu, 8 Sep 2016 18:51:37 +0100 (BST) From: James Simmons To: Baoyou Xie cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, mhocko@suse.com, james.a.nunez@intel.com, uja.ornl@yahoo.com, arnd@arndb.de, kirill.shutemov@linux.intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging/lustre/obdclass: add missing header dependencies In-Reply-To: <1473324367-9172-1-git-send-email-baoyou.xie@linaro.org> Message-ID: References: <1473324367-9172-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160908_185138_085456_45ED92BD X-CRM114-Status: GOOD ( 11.18 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We get 1 warning when building kernel with W=1: > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes] > > In fact, this function is declared in ../../include/obd_class.h, > so this patch add missing header dependencies. > > Signed-off-by: Baoyou Xie Acked-by: James Simmons > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c > index 8f70dd2..2daa834 100644 > --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c > +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c > @@ -45,6 +45,7 @@ > > #include "../../include/obd_support.h" > #include "../../include/lprocfs_status.h" > +#include "../../include/obd_class.h" > > struct static_lustre_uintvalue_attr { > struct { > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel >