From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758476AbcIHR73 (ORCPT ); Thu, 8 Sep 2016 13:59:29 -0400 Received: from casper.infradead.org ([85.118.1.10]:50726 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbcIHR71 (ORCPT ); Thu, 8 Sep 2016 13:59:27 -0400 Date: Thu, 8 Sep 2016 18:59:24 +0100 (BST) From: James Simmons To: Baoyou Xie cc: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, bobijam.xu@intel.com, jinshan.xiong@intel.com, lai.siyao@intel.com, mike.rapoport@gmail.com, amitoj1606@gmail.com, devel@driverdev.osuosl.org, arnd@arndb.de, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging/lustre/lov: add missing header dependencies In-Reply-To: <1473324508-9294-1-git-send-email-baoyou.xie@linaro.org> Message-ID: References: <1473324508-9294-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160908_185924_202445_62602B54 X-CRM114-Status: GOOD ( 12.25 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We get 1 warning when building kernel with W=1: > drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes] > drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes] > > In fact, these functions are declared in ../llite/vvp_internal.h, > so this patch add missing header dependencies. > > Signed-off-by: Baoyou Xie Nak. The header vvp_internal.h is meant to private to the llite layer. Looking at the coming patch updates I see lov_lsm_[put|get] will not be used in the lov later. Now lov_read_and_clear_async is still used in both layers. The header used for this case is cl_object.h. Might rename that function to be consistent with the rest of the header. I will look into a cleanup for this. > --- > drivers/staging/lustre/lustre/lov/lov_object.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c > index f9621b0..912c416 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_object.c > +++ b/drivers/staging/lustre/lustre/lov/lov_object.c > @@ -38,6 +38,7 @@ > #define DEBUG_SUBSYSTEM S_LOV > > #include "lov_cl_internal.h" > +#include "../llite/vvp_internal.h" > > /** \addtogroup lov > * @{ > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel >