From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938769AbcIRUyh (ORCPT ); Sun, 18 Sep 2016 16:54:37 -0400 Received: from casper.infradead.org ([85.118.1.10]:45988 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938673AbcIRUyX (ORCPT ); Sun, 18 Sep 2016 16:54:23 -0400 Date: Sun, 18 Sep 2016 21:53:46 +0100 (BST) From: James Simmons To: Arnd Bergmann cc: Baoyou Xie , oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, di.wang@intel.com, john.hammond@intel.com, fan.yong@intel.com, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] staging: lustre: lmv: add missing function declaration In-Reply-To: <2318806.4yLNEl44ta@wuerfel> Message-ID: References: <1474198793-25108-1-git-send-email-baoyou.xie@linaro.org> <2318806.4yLNEl44ta@wuerfel> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160918_215347_042502_9072EFCC X-CRM114-Status: GOOD ( 10.46 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote: > > > > Nak. I'm not seeing this error with W=1. Also if you look > > lmv_pack_md() is only used in lmv_obd.c and the function > > appears early in the file before it is used, so no prototype > > missing errors should happen. > > So it should be marked "static" and the EXPORT_SYMBOL() removed, > right? Already done. See patch [PATCH 109/124] staging: lustre: misc: remove unnecessary EXPORT_SYMBOL which is from Frank Zago which I just pushed to Greg.