From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755408AbcITPcl (ORCPT ); Tue, 20 Sep 2016 11:32:41 -0400 Received: from casper.infradead.org ([85.118.1.10]:55478 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754586AbcITPcj (ORCPT ); Tue, 20 Sep 2016 11:32:39 -0400 Date: Tue, 20 Sep 2016 16:32:37 +0100 (BST) From: James Simmons To: Dan Carpenter cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, James Simmons , Linux Kernel Mailing List , Oleg Drokin , Lustre Development List Subject: Re: [lustre-devel] [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md In-Reply-To: <20160920111612.GK13620@mwanda> Message-ID: References: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> <20160920064702.GB8527@kroah.com> <20160920085134.GH13620@mwanda> <20160920110500.GB16639@kroah.com> <20160920111612.GK13620@mwanda> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160920_163238_046757_8382EB91 X-CRM114-Status: GOOD ( 23.28 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Tue, Sep 20, 2016 at 11:52:19AM +0300, Dan Carpenter wrote: > > > On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > > > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > > > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > > > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > > > > > was done when porting to the upstream client. > > > > > > > > How did our build testing not catch this? What needs these exports? Is > > > > it any in-kernel code? > > > > > > > > confused, > > > > > > It did catch it... > > > > It did? Works here for me, and I didn't see an error report anywhere... > > > > > James, every patch has to be buildable (bisectable) so the original > > > patch is never going to be merged. > > > > What is the "original" patch here? > > > > [PATCH 112/124] staging: lustre: ptlrpc: remove unnecessary EXPORT_SYMBOL > > kbuild responded to the email that it broke compilation on s360 but I > don't think the breakage is arch specific? But it is. The breakage appears on only a subset of platforms. All the patches I sent are tested on a real file system setup using our special test suite. This was done on x86 hardware where the problem doesn't show up. I guess I need to ask work for a non-x86 platform to test with :-)