From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbcITPwM (ORCPT ); Tue, 20 Sep 2016 11:52:12 -0400 Received: from casper.infradead.org ([85.118.1.10]:56682 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755281AbcITPwL (ORCPT ); Tue, 20 Sep 2016 11:52:11 -0400 Date: Tue, 20 Sep 2016 16:52:07 +0100 (BST) From: James Simmons To: Greg Kroah-Hartman cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , James Simmons , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md In-Reply-To: <20160920111813.GA17691@kroah.com> Message-ID: References: <1474306025-1942-1-git-send-email-jsimmons@infradead.org> <20160920111813.GA17691@kroah.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160920_165207_590056_A6868BD1 X-CRM114-Status: GOOD ( 24.91 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote: > > Being over zealous in removing unused EXPORT_SYMBOLs two functions > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake > > was done when porting to the upstream client. > > > > Signed-off-by: James Simmons > > Reviewed-on: http://review.whamcloud.com/14545 > > Reviewed-on: http://review.whamcloud.com/15159 > > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6486 > > Reviewed-by: Dmitry Eremin > > Reviewed-by: Bob Glossman > > Reviewed-by: John L. Hammond > > Reviewed-by: Oleg Drokin > > Signed-off-by: James Simmons > > --- > > .../staging/lustre/lustre/ptlrpc/pack_generic.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > > index 1349bf6..8717685 100644 > > --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > > +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c > > @@ -1861,6 +1861,7 @@ void lustre_swab_lmv_mds_md(union lmv_mds_md *lmm) > > break; > > } > > } > > +EXPORT_SYMBOL(lustre_swab_lmv_mds_md); > > I don't see anyone else using this symbol, in fact, it could now be > marked static. So why export it? Too soon to export it. A patch is coming in which the llite layer will use it. I will drop it and make a note to make sure for the upcoming patch that I export lustre_swab_lmv_mds_md. > > void lustre_swab_lmv_user_md(struct lmv_user_md *lum) > > { > > @@ -1914,6 +1915,7 @@ void lustre_swab_lov_mds_md(struct lov_mds_md *lmm) > > __swab16s(&lmm->lmm_stripe_count); > > __swab16s(&lmm->lmm_layout_gen); > > } > > +EXPORT_SYMBOL(lustre_swab_lov_mds_md); > > This is used by other files (it's listed twice in lustre_idl.h...), so > it might need to be exported, but why am I not seeing a build error > without this change? The function lustre_swab_lov_mds_md is also used in lov_pack.c so it needs to be exported. You shouldn't be able to load some of the lustre modules but it does on x86. I will send a new patch to fix this but a note about this breakage should be kept so someone with an indepth understanding of the module system can track down what is going wrong.