From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932457AbcITU7R (ORCPT ); Tue, 20 Sep 2016 16:59:17 -0400 Received: from mail-qk0-f175.google.com ([209.85.220.175]:35806 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754320AbcITU6p (ORCPT ); Tue, 20 Sep 2016 16:58:45 -0400 Date: Tue, 20 Sep 2016 16:58:40 -0400 (EDT) From: Nicolas Pitre To: Richard Cochran cc: John Stultz , Thomas Gleixner , Josh Triplett , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] make POSIX timers optional In-Reply-To: <20160920204556.GA7555@localhost.localdomain> Message-ID: References: <1474401400-18491-1-git-send-email-nicolas.pitre@linaro.org> <20160920202556.GA6713@localhost.localdomain> <20160920204556.GA7555@localhost.localdomain> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2016, Richard Cochran wrote: > On Tue, Sep 20, 2016 at 10:25:56PM +0200, Richard Cochran wrote: > > After this series, if I don't pay enough attention to dmesg, then I > > have lost functionality that I had in step #1. That sucks, and it has > > nothing to do with the tinification option at all. It will bite even > > if I have no knowledge of it. That isn't acceptable to me. > > Can't you leave all the "select PTP_1588_CLOCK" alone and simply add > > #ifdef CONFIG_POSIX_TIMERS > // global declarations > #else > // static inlines > #endif > > to ptp_clock_kernel.h, and then sandwich ptp_clock.c in > #ifdef CONFIG_POSIX_TIMERS ... #endif ? Sure I could... but I'm sure I'll be flamed by others for making things even more obscure and hackish than they are right now. Oh well... Let's go fix the Kconfig parser then. Nicolas