From: James Simmons <jsimmons@infradead.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
gregkh@linuxfoundation.org, mhocko@suse.com,
james.a.nunez@intel.com, uja.ornl@yahoo.com, arnd@arndb.de,
kirill.shutemov@linux.intel.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn,
lustre-devel@lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging/lustre/obdclass: add missing header dependencies
Date: Mon, 26 Sep 2016 19:25:32 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609261924400.5573@casper.infradead.org> (raw)
In-Reply-To: <1473324367-9172-1-git-send-email-baoyou.xie@linaro.org>
> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in ../../include/obd_class.h,
> so this patch add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> index 8f70dd2..2daa834 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> @@ -45,6 +45,7 @@
>
> #include "../../include/obd_support.h"
> #include "../../include/lprocfs_status.h"
> +#include "../../include/obd_class.h"
>
> struct static_lustre_uintvalue_attr {
> struct {
> --
> 2.7.4
>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>
prev parent reply other threads:[~2016-09-26 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 8:46 Baoyou Xie
2016-09-08 17:51 ` James Simmons
2016-09-26 18:25 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609261924400.5573@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.a.nunez@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=mhocko@suse.com \
--cc=oleg.drokin@intel.com \
--cc=uja.ornl@yahoo.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®