From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965131AbcKJTpC (ORCPT ); Thu, 10 Nov 2016 14:45:02 -0500 Received: from casper.infradead.org ([85.118.1.10]:33744 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935677AbcKJTpB (ORCPT ); Thu, 10 Nov 2016 14:45:01 -0500 Date: Thu, 10 Nov 2016 19:44:57 +0000 (GMT) From: James Simmons To: Dan Carpenter cc: Oleg Drokin , "John L. Hammond" , Andreas Dilger , Greg Kroah-Hartman , Amitoj Kaur Chawla , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] staging: lustre: lov: crash in error handling In-Reply-To: <20161110194105.GB18347@mwanda> Message-ID: References: <20161110194105.GB18347@mwanda> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161110_194457_256269_08F5E479 X-CRM114-Status: UNSURE ( 7.54 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We accidentally made this unsigned so now the error handling will loop > until it crashes. > > Fixes: 55051039fdad ('staging: lustre: lov: remove LSM from struct lustre_md') > Signed-off-by: Dan Carpenter Yep. I just sent a patch to fix that. > diff --git a/drivers/staging/lustre/lustre/lov/lov_ea.c b/drivers/staging/lustre/lustre/lov/lov_ea.c > index 53db170..2e2abed 100644 > --- a/drivers/staging/lustre/lustre/lov/lov_ea.c > +++ b/drivers/staging/lustre/lustre/lov/lov_ea.c > @@ -81,7 +81,7 @@ struct lov_stripe_md *lsm_alloc_plain(u16 stripe_count) > size_t oinfo_ptrs_size, lsm_size; > struct lov_stripe_md *lsm; > struct lov_oinfo *loi; > - unsigned int i; > + int i; > > LASSERT(stripe_count <= LOV_MAX_STRIPE_COUNT); > >