From: James Simmons <jsimmons@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gregoire Pichon <gregoire.pichon@bull.net>,
Oleg Drokin <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH v4] staging: lustre: mdc: manage number of modify RPCs in flight
Date: Mon, 14 Nov 2016 17:27:00 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.20.1611141722160.29600@casper.infradead.org> (raw)
In-Reply-To: <20161114172047.GA4989@kroah.com>
> On Mon, Nov 14, 2016 at 04:59:48PM +0000, James Simmons wrote:
> >
> > > On Thu, Nov 10, 2016 at 10:51:13AM -0500, James Simmons wrote:
> > > > From: Gregoire Pichon <gregoire.pichon@bull.net>
> > > >
> > > > This patch is the main client part of a new feature that supports
> > > > multiple modify metadata RPCs in parallel. Its goal is to improve
> > > > metadata operations performance of a single client, while maintening
> > > > the consistency of MDT reply reconstruction and MDT recovery
> > > > mechanisms.
> > > >
> > > > It allows to manage the number of modify RPCs in flight within
> > > > the client obd structure and to assign a virtual index (the tag) to
> > > > each modify RPC to help server side cleaning of reply data.
> > > >
> > > > The mdc component uses this feature to send multiple modify RPCs
> > > > in parallel.
> > >
> > > Is this a new feature? Why should we take this now and not just wait
> > > until the code is out of staging?
> >
> > Yes on the server side. So the problem on our meta data servers couldn't
> > handle writing mulitiple bits of data to the back end disk at ths same
> > time.
> >
> > One client side the issue was the metadata operations were being
> > serialized by a mutex in the MDC layer. That is what this patch fixed.
> > So for the client it would be a performance improvement patch.
>
> So, it's a "performance" patch, which isn't functionality, so why should
> we merge this to staging now? Why aren't people working on the known
> coding issues to get this out of staging instead of working on
> performance stuff?
Because the primary goal which the people at my company, not Intel by
the way, wanted was to get this to what is running in production
environments so people would actually use the staging client. When it was
old and broken no one would touch it with a 10 foot pole. The currently
supported verison in production is lustre 2.8.0 so we are only about 30
patches away from reaching the goal. I'm going to respond to your other
email in length about leaving staging. It would be really nice for the
user base if we can reach that goal.
next prev parent reply other threads:[~2016-11-14 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 15:51 James Simmons
2016-11-14 15:17 ` Greg Kroah-Hartman
2016-11-14 16:59 ` James Simmons
2016-11-14 17:20 ` Greg Kroah-Hartman
2016-11-14 17:27 ` James Simmons [this message]
2016-11-15 10:03 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1611141722160.29600@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregoire.pichon@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®