From: James Simmons <jsimmons@infradead.org>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration
Date: Thu, 8 Dec 2016 00:24:42 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.20.1612080024310.14850@casper.infradead.org> (raw)
In-Reply-To: <1481150494-1853127-8-git-send-email-green@linuxhacker.ru>
> Move it to obd.h, so that it's included from both the users and
> the actual definition, making sure they never get out of sync.
> This also silences a sparse warning.
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> ---
> drivers/staging/lustre/lustre/include/obd.h | 3 +++
> drivers/staging/lustre/lustre/llite/vvp_internal.h | 2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/obd.h b/drivers/staging/lustre/lustre/include/obd.h
> index 0f48e9c..1839f4f 100644
> --- a/drivers/staging/lustre/lustre/include/obd.h
> +++ b/drivers/staging/lustre/lustre/include/obd.h
> @@ -43,6 +43,7 @@
> #include "lustre_fld.h"
> #include "lustre_handles.h"
> #include "lustre_intent.h"
> +#include "cl_object.h"
>
> #define MAX_OBD_DEVICES 8192
>
> @@ -76,6 +77,8 @@ static inline void loi_init(struct lov_oinfo *loi)
> struct lov_stripe_md;
> struct obd_info;
>
> +int lov_read_and_clear_async_rc(struct cl_object *clob);
> +
> typedef int (*obd_enqueue_update_f)(void *cookie, int rc);
>
> /* obd info for a particular level (lov, osc). */
> diff --git a/drivers/staging/lustre/lustre/llite/vvp_internal.h b/drivers/staging/lustre/lustre/llite/vvp_internal.h
> index c60d041..f40fd7f 100644
> --- a/drivers/staging/lustre/lustre/llite/vvp_internal.h
> +++ b/drivers/staging/lustre/lustre/llite/vvp_internal.h
> @@ -301,8 +301,6 @@ static inline struct vvp_lock *cl2vvp_lock(const struct cl_lock_slice *slice)
> # define CLOBINVRNT(env, clob, expr) \
> ((void)sizeof(env), (void)sizeof(clob), (void)sizeof(!!(expr)))
>
> -int lov_read_and_clear_async_rc(struct cl_object *clob);
> -
> int vvp_io_init(const struct lu_env *env, struct cl_object *obj,
> struct cl_io *io);
> int vvp_io_write_commit(const struct lu_env *env, struct cl_io *io);
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2016-12-08 0:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 22:41 [PATCH 0/8] Sparse warning fixes in Lustre Oleg Drokin
2016-12-07 22:41 ` [PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs Oleg Drokin
2016-12-08 0:44 ` James Simmons
2016-12-07 22:41 ` [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type Oleg Drokin
2016-12-08 0:16 ` James Simmons
2016-12-08 0:21 ` James Simmons
2016-12-07 22:41 ` [PATCH 3/8] staging/lustre/llite: mark ll_io_init() static Oleg Drokin
2016-12-08 0:24 ` James Simmons
2016-12-07 22:41 ` [PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static Oleg Drokin
2016-12-08 0:23 ` James Simmons
2016-12-07 22:41 ` [PATCH 5/8] staging/lustre/osc: extern declare osc_caches in a header Oleg Drokin
2016-12-08 0:22 ` James Simmons
2016-12-08 0:23 ` James Simmons
2016-12-07 22:41 ` [PATCH 6/8] staging/lustre: Declare lu_context/session_tags_default Oleg Drokin
2016-12-08 0:28 ` James Simmons
2016-12-07 22:41 ` [PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration Oleg Drokin
2016-12-08 0:24 ` James Simmons [this message]
2016-12-07 22:41 ` [PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header Oleg Drokin
2016-12-08 0:25 ` James Simmons
2016-12-08 0:27 ` James Simmons
2016-12-07 23:46 ` [PATCH 0/8] Sparse warning fixes in Lustre Al Viro
2016-12-13 4:07 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1612080024310.14850@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=green@linuxhacker.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®