From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbdALMzV (ORCPT ); Thu, 12 Jan 2017 07:55:21 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:33852 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbdALMzT (ORCPT ); Thu, 12 Jan 2017 07:55:19 -0500 Date: Thu, 12 Jan 2017 12:55:17 +0000 (GMT) From: "Maciej W. Rozycki" To: Bartlomiej Zolnierkiewicz cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 2/2] video: fbdev: pmagb-b-fb: Remove bad `__init' annotation Message-ID: User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix: WARNING: drivers/video/fbdev/pmagb-b-fb.o(.text+0x6dc): Section mismatch in reference from the function pmagbbfb_probe() to the function .init.text:pmagbbfb_erase_cursor() The function pmagbbfb_probe() references the function __init pmagbbfb_erase_cursor(). This is often because pmagbbfb_probe lacks a __init annotation or the annotation of pmagbbfb_erase_cursor is wrong. -- a fallout from a missed update from commit 5b1638d94080 ("VIDEO: PMAGB-B: Fix section mismatch") and then commit 48c68c4f1b54 ("Drivers: video: remove __dev* attributes.") Signed-off-by: Maciej W. Rozycki --- linux-pmagb-b-init.diff Index: linux-20160515-declance-module/drivers/video/fbdev/pmagb-b-fb.c =================================================================== --- linux-20160515-declance-module.orig/drivers/video/fbdev/pmagb-b-fb.c +++ linux-20160515-declance-module/drivers/video/fbdev/pmagb-b-fb.c @@ -133,7 +133,7 @@ static struct fb_ops pmagbbfb_ops = { /* * Turn the hardware cursor off. */ -static void __init pmagbbfb_erase_cursor(struct fb_info *info) +static void pmagbbfb_erase_cursor(struct fb_info *info) { struct pmagbbfb_par *par = info->par;