From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbdATXeU (ORCPT ); Fri, 20 Jan 2017 18:34:20 -0500 Received: from casper.infradead.org ([85.118.1.10]:51548 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752630AbdATXeR (ORCPT ); Fri, 20 Jan 2017 18:34:17 -0500 Date: Fri, 20 Jan 2017 23:34:15 +0000 (GMT) From: James Simmons To: Geliang Tang cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: use i_blocksize() In-Reply-To: Message-ID: References: <0a58b38c7ddfbbc8f56cb8d815114bd4357a6016.1484895399.git.geliangtang@gmail.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170120_233415_153996_8F4B2DD7 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Since i_blocksize() helper has been defined in fs.h, use it instead > of open-coding. The i_blocksize() work hasn't landed to the staging-next tree so this can't land just yet. > Signed-off-by: Geliang Tang > --- > drivers/staging/lustre/lustre/llite/file.c | 2 +- > drivers/staging/lustre/lustre/obdclass/obdo.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c > index d93f06a..3ee546f 100644 > --- a/drivers/staging/lustre/lustre/llite/file.c > +++ b/drivers/staging/lustre/lustre/llite/file.c > @@ -2967,7 +2967,7 @@ int ll_getattr(struct vfsmount *mnt, struct dentry *de, struct kstat *stat) > stat->atime = inode->i_atime; > stat->mtime = inode->i_mtime; > stat->ctime = inode->i_ctime; > - stat->blksize = 1 << inode->i_blkbits; > + stat->blksize = i_blocksize(inode); > > stat->nlink = inode->i_nlink; > stat->size = i_size_read(inode); > diff --git a/drivers/staging/lustre/lustre/obdclass/obdo.c b/drivers/staging/lustre/lustre/obdclass/obdo.c > index b1dfa16..b9be7db 100644 > --- a/drivers/staging/lustre/lustre/obdclass/obdo.c > +++ b/drivers/staging/lustre/lustre/obdclass/obdo.c > @@ -84,7 +84,7 @@ void obdo_from_inode(struct obdo *dst, struct inode *src, u32 valid) > newvalid |= OBD_MD_FLBLOCKS; > } > if (valid & OBD_MD_FLBLKSZ) { /* optimal block size */ > - dst->o_blksize = 1 << src->i_blkbits; > + dst->o_blksize = i_blocksize(src); > newvalid |= OBD_MD_FLBLKSZ; > } > if (valid & OBD_MD_FLTYPE) { > -- > 2.9.3 > >