From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbdFOQGi (ORCPT ); Thu, 15 Jun 2017 12:06:38 -0400 Received: from casper.infradead.org ([85.118.1.10]:59016 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbdFOQGg (ORCPT ); Thu, 15 Jun 2017 12:06:36 -0400 Date: Thu, 15 Jun 2017 17:06:30 +0100 (BST) From: James Simmons To: Joe Perches cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups In-Reply-To: <1497464128.18751.59.camel@perches.com> Message-ID: References: <1497452481-31124-1-git-send-email-jsimmons@infradead.org> <1497452481-31124-6-git-send-email-jsimmons@infradead.org> <1497464128.18751.59.camel@perches.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170615_170630_982115_D891387D X-CRM114-Status: GOOD ( 11.90 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote: > > Cleanup many of the over 80 characters reported by checkpatch > > Please don't let checkpatch get in the way of lustre > readability. > > lustre commonly uses very long identifiers. > Long identifiers and 80 columns don't mix well. > > It might be simpler to declare in some document that > lustre uses lines of up to whatever length and require > that checkpatch should be used with the --max-line-length > option when run on lustre code. Greg would you be okay with this? If we changed to a max-line-length to say 128 thay would mean very few checkpatch issues would remain.