mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Peter Zijlstra <peterz@infradead.org>,
	Matt Hart <matthew.hart@linaro.org>,
	Stefan Agner <stefan@agner.ch>,
	Chris Brandt <chris.brandt@renesas.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL
Date: Fri, 28 Jul 2017 11:27:38 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.20.1707281119450.5981@knanqh.ubzr> (raw)
In-Reply-To: <20170728141108.1283320-1-arnd@arndb.de>

On Fri, 28 Jul 2017, Arnd Bergmann wrote:

> Matt Hart reports that vf610m4_defconfig kernels grew to 2GB
> xipImage size after the __bug_table change.
> 
> I tried out a few things and found that moving the bug table
> into the .data section avoids this problem. However, the
> linker script magic is beyond my capabilities here, so this
> is almost certainly not correct.

Well, before your patch the BUG_TABLE location as well as its runtime 
functionality were completely wrong and broken.

> I've added a few people to Cc that understand this better
> than I do, hopefully someone can turn my bogus patch into
> a proper one.

Your patch isn't as bad as you make it, but maybe the following will 
avoid open recoding BUG_TABLE locally:

diff --git a/arch/arm/kernel/vmlinux-xip.lds.S b/arch/arm/kernel/vmlinux-xip.lds.S
index 8265b11621..21b4b29c2f 100644
--- a/arch/arm/kernel/vmlinux-xip.lds.S
+++ b/arch/arm/kernel/vmlinux-xip.lds.S
@@ -237,13 +237,13 @@ SECTIONS
 		 */
 		DATA_DATA
 		CONSTRUCTORS
-
-		_edata = .;
 	}
-	_edata_loc = __data_loc + SIZEOF(.data);
 
 	BUG_TABLE
 
+	_edata = .;
+	_edata_loc = __data_loc + SIZEOF(.data);
+
 #ifdef CONFIG_HAVE_TCM
         /*
 	 * We align everything to a page boundary so we can


Nicolas

  reply	other threads:[~2017-07-28 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 14:10 Arnd Bergmann
2017-07-28 15:27 ` Nicolas Pitre [this message]
2017-07-28 23:04   ` Ard Biesheuvel
2017-07-28 23:58     ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1707281119450.5981@knanqh.ubzr \
    --to=nicolas.pitre@linaro.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=chris.brandt@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=matthew.hart@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®