From: James Simmons <jsimmons@infradead.org>
To: David Wittman <dwittman@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
jinshan.xiong@intel.com, bobijam.xu@intel.com,
gregkh@linuxfoundation.org, john.hammond@intel.com,
di.wang@intel.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre: declare fiemap_for_stripe static
Date: Thu, 3 Aug 2017 18:27:29 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1708031827000.21881@casper.infradead.org> (raw)
In-Reply-To: <1501647591-22277-1-git-send-email-dwittman@gmail.com>
> Declare fiemap_for_stripe as static to fix sparse warnings:
>
> > warning: symbol 'fiemap_for_stripe' was not declared. Should it be
> > static?
Acked-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: David Wittman <dwittman@gmail.com>
> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index 8fc0bcc..334ecb1 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -1141,11 +1141,11 @@ struct fiemap_state {
> bool fs_enough;
> };
>
> -int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> - struct lov_stripe_md *lsm,
> - struct fiemap *fiemap, size_t *buflen,
> - struct ll_fiemap_info_key *fmkey, int stripeno,
> - struct fiemap_state *fs)
> +static int fiemap_for_stripe(const struct lu_env *env, struct cl_object *obj,
> + struct lov_stripe_md *lsm,
> + struct fiemap *fiemap, size_t *buflen,
> + struct ll_fiemap_info_key *fmkey, int stripeno,
> + struct fiemap_state *fs)
> {
> struct cl_object *subobj;
> struct lov_obd *lov = lu2lov_dev(obj->co_lu.lo_dev)->ld_lov;
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
prev parent reply other threads:[~2017-08-03 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 4:19 David Wittman
2017-08-03 17:27 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1708031827000.21881@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=bobijam.xu@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=di.wang@intel.com \
--cc=dwittman@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jinshan.xiong@intel.com \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®