From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbdHTCxq (ORCPT ); Sat, 19 Aug 2017 22:53:46 -0400 Received: from casper.infradead.org ([85.118.1.10]:38794 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbdHTCxp (ORCPT ); Sat, 19 Aug 2017 22:53:45 -0400 Date: Sun, 20 Aug 2017 03:53:39 +0100 (BST) From: James Simmons To: Greg Kroah-Hartman cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Robin Humble , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH v2 01/14] staging: lustre: llite: Remove filtering of seclabel xattr In-Reply-To: <20170817162348.GA22834@kroah.com> Message-ID: References: <1502727664-29438-1-git-send-email-jsimmons@infradead.org> <1502727664-29438-2-git-send-email-jsimmons@infradead.org> <20170817162348.GA22834@kroah.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170820_035339_999315_EF7060F8 X-CRM114-Status: GOOD ( 20.73 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Aug 14, 2017 at 12:20:51PM -0400, James Simmons wrote: > > From: Robin Humble > > > > The security.capability xattr is used to implement File > > Capabilities in recent Linux versions. Capabilities are a > > fine grained approach to granting executables elevated > > privileges. eg. /bin/ping can have capabilities > > cap_net_admin, cap_net_raw+ep instead of being setuid root. > > > > This xattr has long been filtered out by llite, initially for > > stability reasons (b15587), and later over performance > > concerns as this xattr is read for every file with eg. > > 'ls --color'. Since LU-2869 xattr's are cached on clients, > > alleviating most performance concerns. > > > > Removing llite's filtering of the security.capability xattr > > enables using Lustre as a root filesystem, which is used on > > some large clusters. > > > > Signed-off-by: Robin Humble > > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9562 > > Reviewed-on: https://review.whamcloud.com/27292 > > Reviewed-by: John L. Hammond > > Reviewed-by: Sebastien Buisson > > Reviewed-by: Oleg Drokin > > Signed-off-by: James Simmons > > --- > > Changelog: > > > > v1) Initial submit with wrong patch attached. > > v2) Proper patch this time. > > I don't see a v1 patch anywhere... Its the patch I asked you to drop earlier. Same commit message but I mixed up the patch with another patch. > Anyway, when you do this, please make your subject such that I can sort > the emails properly and they show up in the correct order, so put the > "v2" after the patch number like this: > > Subject: [PATCH 01/14 v2] staging: lustre: llite: Remove filtering of > > I think git does that correctly for you automatically if you use it... Will do.