From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbdJXWUo (ORCPT ); Tue, 24 Oct 2017 18:20:44 -0400 Received: from casper.infradead.org ([85.118.1.10]:43522 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdJXWUm (ORCPT ); Tue, 24 Oct 2017 18:20:42 -0400 Date: Tue, 24 Oct 2017 23:20:35 +0100 (BST) From: James Simmons To: NeilBrown cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] Assorted cleanups for staging/.../lustre/ldlm/ldlm_flock.c In-Reply-To: <150871988297.3340.4522589460981284121.stgit@noble> Message-ID: References: <150871988297.3340.4522589460981284121.stgit@noble> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171024_232035_827966_DF9315DA X-CRM114-Status: GOOD ( 12.61 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This file contains quite a bit of dead code and unused variables. > This patch series cleans it up in various ways. > It should change behaviour at all, just code > readability/maintainabilty. > > I sent the back in July but got not response, possibly because there > were included with other patches which caused a distraction. > So here they are by themselves. Thanks for separating them out. I will give them a spin. > Thanks, > NeilBrown > > > --- > > NeilBrown (9): > staging: lustre: ldlm: remove 'first_enq' arg from ldlm_process_flock_lock() > staging: lustre: ldlm: remove unused 'work_list' arg from ldlm_process_flock_lock() > staging: lustre: ldlm: remove unneeded 'err' arg to ldlm_process_flock_lock() > staging: lustre: ldlm: remove 'flags' arg from ldlm_process_flock_lock() > staging: lustre: ldlm: remove unused 'overlaps' variable > staging: lustre: ldlm: remove 'flags' arg from ldlm_flock_destroy() > staging: lustre: ldlm: tidy list walking in ldlm_flock() > staging: lustre: ldlm: remove unnecessary 'ownlocks' variable. > staging: lustre: ldlm: remove unused field 'fwd_generation' > > > drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 208 +++++------------------ > 1 file changed, 42 insertions(+), 166 deletions(-) > > -- > Signature > >