From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932513AbdJZPzO (ORCPT ); Thu, 26 Oct 2017 11:55:14 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:49063 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932456AbdJZPzG (ORCPT ); Thu, 26 Oct 2017 11:55:06 -0400 X-Google-Smtp-Source: ABhQp+RFluNdMyBBAumhrRrcNQE7z4gypCp7Tb8H5f4AciMsACEjQGRRyPdMNee1nQ15lzvmU7dZaQ== Date: Thu, 26 Oct 2017 17:55:02 +0200 (CEST) From: Linus Torvalds To: Andy Lutomirski cc: X86 ML , Borislav Petkov , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen Subject: Re: [PATCH 00/18] Pile o' entry/exit/sp0 changes In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Oct 2017, Andy Lutomirski wrote: > > Here's the first "real" version of this series. It's based on Linus' > tree from a couple days ago. Not seeing any problems in this series. I was hoping it would remove more lines of code than it adds, and it's the reverse, but that seems to be mostly the new push/pop stuff. I'm taking it we couldn't just replace the 'mov' instructions in the save/restore macros.. I *do* ask that when we have code like this: POP_EXTRA_REGS POP_C_REGS addq $8, %rsp that "addq $8" would have a comment about what stack entry we're skipping. I *think* it's 'orig_eax', but wouldn't it be nice to say so? Linus