From: Sebastian Ott <sebott@linux.vnet.ibm.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [bisected] system hang after boot
Date: Mon, 27 Nov 2017 14:05:25 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.21.1711271403550.1783@schleppi> (raw)
In-Reply-To: <20171127124506.GB30679@arm.com>
On Mon, 27 Nov 2017, Will Deacon wrote:
> Sebastian: could you try the diff below, please? If that fixes s390, then
> we can debate the merits of GENERIC_LOCKBREAK independently of fixing this
> issue.
>
> Thanks,
>
> Will
>
> --->8
>
> diff --git a/kernel/locking/spinlock.c b/kernel/locking/spinlock.c
> index 1fd1a7543cdd..0ebb253e2199 100644
> --- a/kernel/locking/spinlock.c
> +++ b/kernel/locking/spinlock.c
> @@ -68,8 +68,8 @@ void __lockfunc __raw_##op##_lock(locktype##_t *lock) \
> \
> if (!(lock)->break_lock) \
> (lock)->break_lock = 1; \
> - while ((lock)->break_lock) \
> - arch_##op##_relax(&lock->raw_lock); \
> + \
> + arch_##op##_relax(&lock->raw_lock); \
> } \
> (lock)->break_lock = 0; \
> } \
> @@ -88,8 +88,8 @@ unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock) \
> \
> if (!(lock)->break_lock) \
> (lock)->break_lock = 1; \
> - while ((lock)->break_lock) \
> - arch_##op##_relax(&lock->raw_lock); \
> + \
> + arch_##op##_relax(&lock->raw_lock); \
> } \
> (lock)->break_lock = 0; \
> return flags; \
I tested that on top of 4.15.0-rc1 and it worked!
Sebastian
next prev parent reply other threads:[~2017-11-27 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 17:46 Sebastian Ott
2017-11-22 18:26 ` Will Deacon
2017-11-22 18:54 ` Sebastian Ott
2017-11-22 19:10 ` Will Deacon
2017-11-22 20:22 ` Peter Zijlstra
2017-11-27 11:49 ` Will Deacon
2017-11-27 12:45 ` Will Deacon
2017-11-27 13:05 ` Sebastian Ott [this message]
2017-11-27 12:49 ` Martin Schwidefsky
2017-11-27 12:54 ` Will Deacon
2017-11-27 13:00 ` Martin Schwidefsky
2017-11-27 13:10 ` Will Deacon
2017-11-27 13:13 ` Peter Zijlstra
2017-11-27 13:12 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1711271403550.1783@schleppi \
--to=sebott@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome