From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013AbeAQP06 (ORCPT + 1 other); Wed, 17 Jan 2018 10:26:58 -0500 Received: from casper.infradead.org ([85.118.1.10]:33182 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753388AbeAQP0y (ORCPT ); Wed, 17 Jan 2018 10:26:54 -0500 Date: Wed, 17 Jan 2018 15:26:48 +0000 (GMT) From: James Simmons To: NeilBrown cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lkml , lustre Subject: Re: [PATCH 02/19] staging: lustre: discard SVC_SIGNAL and related functions In-Reply-To: <151538209333.23920.9948001896186855872.stgit@noble> Message-ID: References: <151538168618.23920.8261096424342988792.stgit@noble> <151538209333.23920.9948001896186855872.stgit@noble> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180117_152648_815394_23252BF5 X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > This flag is never set, so remove checks and remove > the flag. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/include/lustre_net.h | 6 ------ > drivers/staging/lustre/lustre/ptlrpc/sec_gc.c | 4 +--- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/include/lustre_net.h b/drivers/staging/lustre/lustre/include/lustre_net.h > index 3ff5de4770e8..4c665eca2467 100644 > --- a/drivers/staging/lustre/lustre/include/lustre_net.h > +++ b/drivers/staging/lustre/lustre/include/lustre_net.h > @@ -1260,7 +1260,6 @@ enum { > SVC_STARTING = 1 << 2, > SVC_RUNNING = 1 << 3, > SVC_EVENT = 1 << 4, > - SVC_SIGNAL = 1 << 5, > }; > > #define PTLRPC_THR_NAME_LEN 32 > @@ -1333,11 +1332,6 @@ static inline int thread_is_event(struct ptlrpc_thread *thread) > return !!(thread->t_flags & SVC_EVENT); > } > > -static inline int thread_is_signal(struct ptlrpc_thread *thread) > -{ > - return !!(thread->t_flags & SVC_SIGNAL); > -} > - > static inline void thread_clear_flags(struct ptlrpc_thread *thread, __u32 flags) > { > thread->t_flags &= ~flags; > diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c > index 8d1e0edfcede..d85c8638c009 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/sec_gc.c > @@ -153,7 +153,6 @@ static int sec_gc_main(void *arg) > while (1) { > struct ptlrpc_sec *sec; > > - thread_clear_flags(thread, SVC_SIGNAL); > sec_process_ctx_list(); > again: > /* go through sec list do gc. > @@ -184,8 +183,7 @@ static int sec_gc_main(void *arg) > lwi = LWI_TIMEOUT(msecs_to_jiffies(SEC_GC_INTERVAL * MSEC_PER_SEC), > NULL, NULL); > l_wait_event(thread->t_ctl_waitq, > - thread_is_stopping(thread) || > - thread_is_signal(thread), > + thread_is_stopping(thread), > &lwi); > > if (thread_test_and_clear_flags(thread, SVC_STOPPING)) > > >