From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouuG2WINgSd/rF7YV1l4q7HM5VBg3Soo2HNCJW98a6iz4NsOVj6OC6rH5OqdU4cyB1Zg1Ds ARC-Seal: i=1; a=rsa-sha256; t=1516203319; cv=none; d=google.com; s=arc-20160816; b=vKpC5bPbJKwm+a8SNH7W6p8UBQL6FSWHlgwIRUpDUQJ4DiGtmkmCFnRNYTwFrtYH9Q o63Ml/ljJB0kWZymXf0pAOv7TULSFgOz/cgYY1hbfN7JDttJOqKpwVz3xjIrXzYcaPwh BYb6683wP1xtgah0R0jXw85KI8IKnv9sk+ON46fwxPOjnMD3tNrC7YgM/rC/06xLwg9S 3KKtE7Ab9TxiGIPr3NAySdYzNtJ2WsLV9fuoOIPCDJUrCZ/PMAg0mke83niha7Grm+Ko rGQOb6fJURtWd75kdRl6W5r7wkauffloAQWYo5x8qKhVY129RwpjFCcxIV6tLNCHGlza DGbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:dkim-signature:arc-authentication-results; bh=Vf1uu47+8kCWI4wlBb+3rhRJjuqy/wC89SC7jx27u1k=; b=tQ4dDnDy7+84CVhb5kbeShrU62Bsf4niyWGcKqsDmOsd4RoUK4rdAoAV0mz5dxQj93 SwvuJgs/hdGBYbUKnDzj9xhoNlWBNUGuvh9nK5mBGut1cSzkNx+c6hdE+Eha/gMWcW5G 8PfolmXOR6DwD30jE1EO3usbjTTAKG2mwn3qAb8Pj0Lmy2jF3nrVp4wBJAAhhn1bl+JU esFcQhaEOoge94Vo8v+Cs9PmQCyZbGSMBvAEDyGVn4ocLEjA/yrUCMpydSB6elmYeF2S zYGz/QUMn6Kmu72rGSGFMRRnMof07t6c8lOpww8Vcp5uZh8VqYkoExBZrPBsqy2kuW5Q drVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oiGWi4u1; spf=pass (google.com: best guess record for domain of jsimmons@infradead.org designates 2001:8b0:10b:1236::1 as permitted sender) smtp.mailfrom=jsimmons@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=oiGWi4u1; spf=pass (google.com: best guess record for domain of jsimmons@infradead.org designates 2001:8b0:10b:1236::1 as permitted sender) smtp.mailfrom=jsimmons@infradead.org Date: Wed, 17 Jan 2018 15:35:14 +0000 (GMT) From: James Simmons To: NeilBrown cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lkml , lustre Subject: Re: [PATCH 15/19] staging: lustre: use explicit poll loop in ptlrpc_service_unlink_rqbd In-Reply-To: <151538209387.23920.11031149890821644565.stgit@noble> Message-ID: References: <151538168618.23920.8261096424342988792.stgit@noble> <151538209387.23920.11031149890821644565.stgit@noble> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180117_153514_782478_6B1FD01B X-CRM114-Status: GOOD ( 12.47 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1588993468138535555?= X-GMAIL-MSGID: =?utf-8?q?1589854411888594637?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > Rather an using l_wait_event(), use wait_event_idle_timeout() > with an explicit loop so it is easier to see what is happening. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/ptlrpc/service.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c b/drivers/staging/lustre/lustre/ptlrpc/service.c > index 5c41297d23d2..6e3403417434 100644 > --- a/drivers/staging/lustre/lustre/ptlrpc/service.c > +++ b/drivers/staging/lustre/lustre/ptlrpc/service.c > @@ -2618,7 +2618,7 @@ ptlrpc_service_unlink_rqbd(struct ptlrpc_service *svc) > { > struct ptlrpc_service_part *svcpt; > struct ptlrpc_request_buffer_desc *rqbd; > - struct l_wait_info lwi; > + int cnt; > int rc; > int i; > > @@ -2658,12 +2658,13 @@ ptlrpc_service_unlink_rqbd(struct ptlrpc_service *svc) > * the HUGE timeout lets us CWARN for visibility > * of sluggish LNDs > */ > - lwi = LWI_TIMEOUT_INTERVAL( > - LONG_UNLINK * HZ, > - HZ, NULL, NULL); > - rc = l_wait_event(svcpt->scp_waitq, > - svcpt->scp_nrqbds_posted == 0, &lwi); > - if (rc == -ETIMEDOUT) { > + cnt = 0; > + while (cnt < LONG_UNLINK && > + (rc = wait_event_idle_timeout(svcpt->scp_waitq, > + svcpt->scp_nrqbds_posted == 0, > + HZ)) == 0) > + cnt ++; > + if (rc == 0) { > CWARN("Service %s waiting for request buffers\n", > svcpt->scp_service->srv_name); > } > > >