From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBovbjr3SPeSt5exsLbfNPAEjF1qBZUNIDPMMwyxk9C1927ULqERY51UGiTkaHDcRcA6abqrI ARC-Seal: i=1; a=rsa-sha256; t=1516205155; cv=none; d=google.com; s=arc-20160816; b=OcM2PTMa3rWBWeVq8wPHN+DG9MSKaCfsw7TXjzCpyjhLkrEgJ02N6H8T1cEecmZFuQ p4WQ0bKk00o9jeWbyBpAsgDZgokkYZ0BTbCo1cISjzW78Uu58MiRruPJiTbNwPtpsey+ NyDjEY0KQF4xMqlXq2yRVA61ZERSaVly6zM3HDtMC1edcmNUBmw7Y6ni+O4SmUqZhSXP 0evXUHkGATq7ZGMysytrDCszNNTgyQlgmLZTg4EBJE92+oauZFH+hjFmjLljIqlTxX5N YEc42Slfb+0yOdRwNjdAWGNaRUrIQ5mADVsi2IPQ61uPjOqEy+ucPWjq/AksMrtIpF49 3g1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:dkim-signature:arc-authentication-results; bh=ysSKIeiWyPyh2Djkl2junwkMUBzuU0wI2gKWLT4+iJg=; b=dF5rHP4t3oyfTtTbrYYh7zYgeW7cMhl+xOu5O7V/L0HBYopBnvpl4DSMBhkWLzL5xV KT/Zg8HfiNJAT0tslRyeQB24WL6gf3SbKEPBEes/lnmmxN76MsZ3eH9GOaAuYXcK9cjf w4zUbMEM6LF99lRUYQQw0aFi1CFLHFyw+QZYlAh84FlK+NppUKcFewAiwzKK1IXy55zh nt4I06ur2iTEb5n+U22dkMrdKTs3Ac7gXpU7Fu1wrShpxBWGN11wDPVNZkNLEiIE0MXf jyDzIkud48T7dqPMIEgefURi9WPArIOCGdppaTf+lkbJkNovxme+APXt/ZUuCMibz1Qd dRVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hEpjXT1W; spf=pass (google.com: best guess record for domain of jsimmons@infradead.org designates 2001:8b0:10b:1236::1 as permitted sender) smtp.mailfrom=jsimmons@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=hEpjXT1W; spf=pass (google.com: best guess record for domain of jsimmons@infradead.org designates 2001:8b0:10b:1236::1 as permitted sender) smtp.mailfrom=jsimmons@infradead.org Date: Wed, 17 Jan 2018 16:05:45 +0000 (GMT) From: James Simmons To: Arnd Bergmann cc: Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , NeilBrown , Tejun Heo , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: lustre: lnet: avoid uninitialized return value In-Reply-To: <20180116093511.3197459-1-arnd@arndb.de> Message-ID: References: <20180116093511.3197459-1-arnd@arndb.de> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180117_160545_460505_A4375B79 X-CRM114-Status: GOOD ( 15.75 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589741167499317038?= X-GMAIL-MSGID: =?utf-8?q?1589856336683206841?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > gcc warns that the latest workqueue change leads to returning an > uninitialized variable: > > drivers/staging/lustre/lnet/selftest/module.c: In function 'lnet_selftest_init': > drivers/staging/lustre/lnet/selftest/module.c:98:10: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > A failure from alloc_ordered_workqueue() tends to indicate an > out-of-memory condition, so return -ENOMEM in both cases. > The second error path was a preexisting bug, where we always > returned zero after a kvmalloc_array() failure. Reviewed-by: James Simmons > Fixes: 6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues") > Signed-off-by: Arnd Bergmann > --- > drivers/staging/lustre/lnet/selftest/module.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c > index aa6bfd5baf2f..c8d999e64f28 100644 > --- a/drivers/staging/lustre/lnet/selftest/module.c > +++ b/drivers/staging/lustre/lnet/selftest/module.c > @@ -95,15 +95,17 @@ lnet_selftest_init(void) > lst_serial_wq = alloc_ordered_workqueue("lst_s", 0); > if (!lst_serial_wq) { > CERROR("Failed to create serial WI scheduler for LST\n"); > - return rc; > + return -ENOMEM; > } > lst_init_step = LST_INIT_WI_SERIAL; > > nscheds = cfs_cpt_number(lnet_cpt_table()); > lst_test_wq = kvmalloc_array(nscheds, sizeof(lst_test_wq[0]), > GFP_KERNEL | __GFP_ZERO); > - if (!lst_test_wq) > + if (!lst_test_wq) { > + rc = -ENOMEM; > goto error; > + } > > lst_init_step = LST_INIT_WI_TEST; > for (i = 0; i < nscheds; i++) { > @@ -116,6 +118,7 @@ lnet_selftest_init(void) > if (!lst_test_wq[i]) { > CWARN("Failed to create CPU partition affinity WI scheduler %d for LST\n", > i); > + rc = -ENOMEM; > goto error; > } > attrs.nice = 0; > -- > 2.9.0 > >