From: James Simmons <jsimmons@infradead.org>
To: NeilBrown <neilb@suse.com>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 3/3] staging: lustre: lnet/selftest: don't ignore status from lstcon_test_add
Date: Mon, 26 Feb 2018 14:48:48 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1802261448360.13228@casper.infradead.org> (raw)
In-Reply-To: <151933737388.16436.11922095105762928334.stgit@noble>
> If lstcon_test_add sets 'ret' (passed by reference) to 1,
> then lst_test_add_ioctl() ignores the return value.
> This isn't justified - the return value must be zero for 'ret'
> to be meaningful.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lnet/selftest/conctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging/lustre/lnet/selftest/conctl.c
> index 51497cf9a832..a2d8092bdeb7 100644
> --- a/drivers/staging/lustre/lnet/selftest/conctl.c
> +++ b/drivers/staging/lustre/lnet/selftest/conctl.c
> @@ -670,7 +670,7 @@ static int lst_test_add_ioctl(struct lstio_test_args *args)
> args->lstio_tes_param_len,
> &ret, args->lstio_tes_resultp);
>
> - if (ret)
> + if (!rc && ret)
> rc = (copy_to_user(args->lstio_tes_retp, &ret,
> sizeof(ret))) ? -EFAULT : 0;
> out:
>
>
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-02-26 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 22:09 [PATCH 0/3] Three lustre bugfixes NeilBrown
2018-02-22 22:09 ` [PATCH 1/3] staging: lustre: lov: use correct env in lov_io_data_version_end() NeilBrown
2018-02-26 14:47 ` James Simmons
2018-02-22 22:09 ` [PATCH 2/3] staging: lustre: lmv: correctly iput lmo_root NeilBrown
2018-02-26 14:48 ` James Simmons
2018-02-22 22:09 ` [PATCH 3/3] staging: lustre: lnet/selftest: don't ignore status from lstcon_test_add NeilBrown
2018-02-26 14:48 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1802261448360.13228@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=neilb@suse.com \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®