From: Sebastian Ott <sebott@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org
Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7
Date: Tue, 27 Mar 2018 19:04:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1803271900390.18934@schleppi> (raw)
In-Reply-To: <20180327164505.GA10522@lst.de>
On Tue, 27 Mar 2018, Christoph Hellwig wrote:
> On Tue, Mar 27, 2018 at 05:24:10PM +0200, Sebastian Ott wrote:
> > What do you mean by current implementations? Arch specific code? At least
> > on s390 we don't do that. dma-mapping.h doesn't do it either.
>
> The arch implementations should do it. Seems like s390 and potentially
> a few others don't. I'm a little slow due to a cast on one arm, but I'll
> do an audit and will fix up anything I'll find.
What was wrong with the old behavior (let the caller decide - the same
as with memory allocations)? We have interfaces like dma_zalloc_coherent,
which explicitely set __GFP_ZERO. We have callers of dma_alloc followed by
a manually memset..
Sebastian
next prev parent reply other threads:[~2018-03-27 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 8:12 Sebastian Ott
2018-03-27 8:21 ` Geert Uytterhoeven
2018-03-27 8:41 ` Sebastian Ott
2018-03-27 8:51 ` Geert Uytterhoeven
2018-03-27 14:33 ` Christoph Hellwig
2018-03-27 15:24 ` Sebastian Ott
2018-03-27 16:45 ` Christoph Hellwig
2018-03-27 17:04 ` Sebastian Ott [this message]
2018-03-28 11:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1803271900390.18934@schleppi \
--to=sebott@linux.vnet.ibm.com \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®