From: James Simmons <jsimmons@infradead.org>
To: NeilBrown <neilb@suse.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 02/17] staging: lustre: remove unused ldlm_completion_ast_async()
Date: Fri, 30 Mar 2018 19:57:08 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.1803301957010.9681@casper.infradead.org> (raw)
In-Reply-To: <152229760829.27689.12680083968318847851.stgit@noble>
> This function is unused.
Reviewed-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_dlm.h | 1 -
> drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 23 --------------------
> 2 files changed, 24 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_dlm.h b/drivers/staging/lustre/lustre/include/lustre_dlm.h
> index 239aa2b1268f..7407acf60cf8 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_dlm.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_dlm.h
> @@ -1227,7 +1227,6 @@ int ldlm_lock_change_resource(struct ldlm_namespace *, struct ldlm_lock *,
> * processing.
> * @{
> */
> -int ldlm_completion_ast_async(struct ldlm_lock *lock, __u64 flags, void *data);
> int ldlm_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data);
> /** @} ldlm_local_ast */
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> index c3c9186b74ce..be43958e4090 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> @@ -191,29 +191,6 @@ static int ldlm_completion_tail(struct ldlm_lock *lock, void *data)
> return result;
> }
>
> -/**
> - * Implementation of ->l_completion_ast() for a client, that doesn't wait
> - * until lock is granted. Suitable for locks enqueued through ptlrpcd, of
> - * other threads that cannot block for long.
> - */
> -int ldlm_completion_ast_async(struct ldlm_lock *lock, __u64 flags, void *data)
> -{
> - if (flags == LDLM_FL_WAIT_NOREPROC) {
> - LDLM_DEBUG(lock, "client-side enqueue waiting on pending lock");
> - return 0;
> - }
> -
> - if (!(flags & LDLM_FL_BLOCKED_MASK)) {
> - wake_up(&lock->l_waitq);
> - return ldlm_completion_tail(lock, data);
> - }
> -
> - LDLM_DEBUG(lock,
> - "client-side enqueue returned a blocked lock, going forward");
> - return 0;
> -}
> -EXPORT_SYMBOL(ldlm_completion_ast_async);
> -
> /**
> * Generic LDLM "completion" AST. This is called in several cases:
> *
>
>
>
next prev parent reply other threads:[~2018-03-30 18:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 4:26 [PATCH 00/17] staging: Assorted lustre cleanup NeilBrown
2018-03-29 4:26 ` [PATCH 07/17] staging: lustre: ldlm: free resource when ldlm_lock_create() fails NeilBrown
2018-03-30 18:58 ` James Simmons
2018-03-29 4:26 ` [PATCH 04/17] staging: lustre: remove unused hash tables NeilBrown
2018-03-30 18:57 ` James Simmons
2018-03-29 4:26 ` [PATCH 14/17] staging: lustre: discard cfs_duration_sec() NeilBrown
2018-03-30 19:02 ` James Simmons
2018-03-29 4:26 ` [PATCH 01/17] staging: lustre: remove invariant in cl_io_read_ahead() NeilBrown
2018-03-30 18:56 ` James Simmons
2018-03-29 4:26 ` [PATCH 16/17] staging: lustre: discard linux-time.h NeilBrown
2018-03-30 19:03 ` James Simmons
2018-03-29 4:26 ` [PATCH 05/17] staging: lustre: remove unneeded include NeilBrown
2018-03-30 18:57 ` James Simmons
2018-03-29 4:26 ` [PATCH 11/17] staging: lustre: libcfs: discard cfs_time_shift() NeilBrown
2018-03-30 19:02 ` James Simmons
2018-04-02 19:34 ` Dilger, Andreas
2018-04-02 22:26 ` NeilBrown
2018-04-04 8:10 ` [lustre-devel] " Dilger, Andreas
2018-04-04 22:00 ` NeilBrown
2018-03-29 4:26 ` [PATCH 15/17] staging: lustre: discard cfs_time_before_64() NeilBrown
2018-03-30 19:03 ` James Simmons
2018-03-29 4:26 ` [PATCH 17/17] staging: lustre: remove cruft from libcfs/linux/libcfs.h NeilBrown
2018-03-30 19:07 ` James Simmons
2018-03-29 4:26 ` [PATCH 09/17] staging: lustre: cfs_time_current() -> jiffies NeilBrown
2018-03-30 19:00 ` James Simmons
2018-03-29 4:26 ` [PATCH 10/17] staging: lustre: libcfs: discard cfs_time_add/sub NeilBrown
2018-03-30 19:00 ` James Simmons
2018-03-29 4:26 ` [PATCH 03/17] staging: lustre: LNET excludes USERIO NeilBrown
2018-03-30 19:09 ` James Simmons
2018-03-29 4:26 ` [PATCH 13/17] staging: lustre: libcfs: remove cfs_timeout_cap() NeilBrown
2018-03-30 19:03 ` James Simmons
2018-04-02 19:38 ` Dilger, Andreas
2018-04-02 22:34 ` NeilBrown
2018-03-29 4:26 ` [PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref() NeilBrown
2018-03-30 18:58 ` James Simmons
2018-03-29 4:26 ` [PATCH 02/17] staging: lustre: remove unused ldlm_completion_ast_async() NeilBrown
2018-03-30 18:57 ` James Simmons [this message]
2018-03-29 4:26 ` [PATCH 08/17] staging: lustre: add container_of_safe() NeilBrown
2018-03-30 18:59 ` James Simmons
2018-04-23 13:16 ` Greg Kroah-Hartman
2018-03-29 4:26 ` [PATCH 12/17] staging: lustre: libcfs: discard cfs_time_after() NeilBrown
2018-03-30 19:01 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1803301957010.9681@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=neilb@suse.com \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®