From: Jules Irenge <jbi.octave@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Jules Irenge <jbi.octave@gmail.com>,
outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
eric@anholt.net, wahrenst@gmx.net, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org, daniela.mormocea@gmail.com,
dave.stevenson@raspberrypi.org, hverkuil-cisco@xs4all.nl,
mchehab+samsung@kernel.org,
bcm-kernel-feedback-list@broadcom.com, sbranden@broadcom.com,
rjui@broadcom.com, f.fainelli@gmail.com
Subject: Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line
Date: Sat, 12 Oct 2019 16:00:59 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.1910121551090.15982@ninjahub.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1910112336440.3284@hadrien>
On Fri, 11 Oct 2019, Julia Lawall wrote:
>
>
> On Fri, 11 Oct 2019, Jules Irenge wrote:
>
>> Fix warning of logical continuations should be on the previous line.
>> Issue detected by checkpatch tool.
>
> There seem to be several changes mixed together in this patch.
>
> Don't have a subject line that is identical to a line in the log message.
> The subject line should be short.
>
> Keeping the arguments of && on the same line, but breaking the line after
> a == doesn't seem to be a good idea. It would be better to have the left
> argument of == on one line and the right argument on another, if that is
> needed.
>
> julia
>
Apology,
Yesterday was my bday, I was reckless.
I am resending now. Please do not hesitate to give me a feedback if
possible.
Thanks
Jules
prev parent reply other threads:[~2019-10-12 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 21:27 Jules Irenge
2019-10-11 21:38 ` [Outreachy kernel] " Julia Lawall
2019-10-12 15:00 ` Jules Irenge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1910121551090.15982@ninjahub.org \
--to=jbi.octave@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniela.mormocea@gmail.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab+samsung@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®