From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF33C4361B for ; Sun, 6 Dec 2020 14:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C51DF23142 for ; Sun, 6 Dec 2020 14:34:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgLFOey (ORCPT ); Sun, 6 Dec 2020 09:34:54 -0500 Received: from [157.25.102.26] ([157.25.102.26]:54072 "EHLO orcam.me.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726203AbgLFOex (ORCPT ); Sun, 6 Dec 2020 09:34:53 -0500 Received: from bugs.linux-mips.org (eddie.linux-mips.org [IPv6:2a01:4f8:201:92aa::3]) by orcam.me.uk (Postfix) with ESMTPS id 0470E2BE0EC; Sun, 6 Dec 2020 14:34:20 +0000 (GMT) Date: Sun, 6 Dec 2020 14:33:33 +0000 (GMT) From: "Maciej W. Rozycki" To: Anders Roxell cc: Thomas Bogendoerfer , natechancellor@gmail.com, ndesaulniers@google.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp' In-Reply-To: Message-ID: References: <20201127083938.2666770-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 6 Dec 2020, Maciej W. Rozycki wrote: > I think this should be OK once the issues I mentioned here have been > addressed. Or alternatively making the variable global would possibly be a better fix as it would let the compiler decide if to waste another register to keep a copy of $sp. Maciej