From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-usb@vger.kernel.org
Cc: Roman Weissgaerber <weissg@vienna.at>,
Lennert Buytenhek <kernel@wantstofly.org>,
Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] test for NULL return from platform_get_resource() in ohci_hcd_sm501_drv_remove()
Date: Fri, 21 Mar 2008 22:55:45 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.1.00.0803212250210.9597@dragon.funnycrock.com> (raw)
platform_get_resource() may return null, so although it seems it will never
do so here unless there's a bug elsewhere, it does no harm to be defensive
and test.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
ohci-sm501.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
index a970701..1ffc272 100644
--- a/drivers/usb/host/ohci-sm501.c
+++ b/drivers/usb/host/ohci-sm501.c
@@ -199,7 +199,8 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
usb_put_hcd(hcd);
dma_release_declared_memory(&pdev->dev);
mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- release_mem_region(mem->start, mem->end - mem->start + 1);
+ if (mem)
+ release_mem_region(mem->start, mem->end - mem->start + 1);
/* mask interrupts and disable power */
next reply other threads:[~2008-03-21 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 21:55 Jesper Juhl [this message]
2008-03-27 19:27 ` David Brownell
2008-03-28 8:48 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.00.0803212250210.9597@dragon.funnycrock.com \
--to=jesper.juhl@gmail.com \
--cc=greg@kroah.com \
--cc=kernel@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=weissg@vienna.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®