From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932904AbYDVW25 (ORCPT ); Tue, 22 Apr 2008 18:28:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758490AbYDVW2s (ORCPT ); Tue, 22 Apr 2008 18:28:48 -0400 Received: from fg-out-1718.google.com ([72.14.220.154]:53859 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758370AbYDVW2p (ORCPT ); Tue, 22 Apr 2008 18:28:45 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:to:cc:subject:message-id:user-agent:mime-version:content-type:from; b=s7qSxJ4195Y2CKG/9xTj2SM/XtU4jqvQA/Co2S96ZJZnDmQz2YDaNfQ9eF+wc0YS6bGGsvtNV8mMW4s6hrUjlNpxgXMm+kHDHTcemwEr1T4CB5/lrfYagdwOFjq8ySn6t7uF+4IBAEZRtw5emw9HDoh6fzssG55sLMbvXycW8y0= Date: Wed, 23 Apr 2008 00:28:47 +0200 (CEST) To: Shaohua Li cc: linux-kernel@vger.kernel.org, Ingo Molnar , Jesper Juhl Subject: [PATCH] PCI Express ASPM support should default to 'No' Message-ID: User-Agent: Alpine 1.00 (LNX 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII From: Jesper Juhl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Running 'make oldconfig' I just noticed that PCIEASPM defaults to 'y' in Kconfig even though the feature is both experimental and the help text recommends that if you are unsure you say 'n'. It seems to me that this really should default to 'n', not 'y' at the moment. The following patch makes that change. Please consider applying. Signed-off-by: Jesper Juhl --- Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index 25b04fb..5a0c6ad 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -33,7 +33,7 @@ source "drivers/pci/pcie/aer/Kconfig" config PCIEASPM bool "PCI Express ASPM support(Experimental)" depends on PCI && EXPERIMENTAL && PCIEPORTBUS - default y + default n help This enables PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supports state L0/L0s/L1.