mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Andi Kleen <andi@firstfloor.org>,
	Jesper Juhl <jesper.juhl@gmail.com>,
	trivial@kernel.org
Subject: [PATCH][Resend] PCI Express ASPM support should default to 'No'
Date: Sun, 27 Apr 2008 22:07:40 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.1.00.0804272159520.2352@dragon.funnycrock.com> (raw)

From: Jesper Juhl <jesper.juhl@gmail.com>

[This patch was previously submitted  23 April 2008 00:28]

Andrew; if you could merge this in -mm it would be good, otherwise I'll 
just queue it up in the trivial tree for the next merge window.


Running 'make oldconfig' I just noticed that PCIEASPM defaults to 
'y' in Kconfig even though the feature is experimental and the 
help text recommends that if you are unsure you say 'n'.
It seems to me that this really should default to 'n', not 'y'.
The following patch makes that change. Please consider merging.

Jesse Barnes commented on the patch that it "Seem reasonable".
Shaohua Li also commented saying "Ok, I'm fine with the patch."

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 25b04fb..5a0c6ad 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -33,7 +33,7 @@ source "drivers/pci/pcie/aer/Kconfig"
 config PCIEASPM
 	bool "PCI Express ASPM support(Experimental)"
 	depends on PCI && EXPERIMENTAL && PCIEPORTBUS
-	default y
+	default n
 	help
 	  This enables PCI Express ASPM (Active State Power Management) and
 	  Clock Power Management. ASPM supports state L0/L0s/L1.



             reply	other threads:[~2008-04-27 20:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27 20:07 Jesper Juhl [this message]
2008-04-27 21:24 ` Jesse Barnes
2008-04-27 21:35   ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.1.00.0804272159520.2352@dragon.funnycrock.com \
    --to=jesper.juhl@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=shaohua.li@intel.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®