mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Barkalow <barkalow@iabervon.org>
To: Mark Lord <liml@rtr.ca>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Tejun Heo <htejun@gmail.com>, Jeff Garzik <jgarzik@pobox.com>,
	linux-pci@vger.kernel.org
Subject: Re: libata, devm_*, and MSI ?
Date: Tue, 20 Jan 2009 16:50:41 -0500 (EST)	[thread overview]
Message-ID: <alpine.LNX.1.00.0901201626090.19665@iabervon.org> (raw)
In-Reply-To: <4975F5C1.8090107@rtr.ca>

On Tue, 20 Jan 2009, Mark Lord wrote:

> Next, there's no mention of a need for invoking pci_intx() in the HOW-TO,
> yet some device drivers call it, and others do not.

Some devices don't work if you call it (don't send any interrupts); others 
don't work if you don't call it (send both types of interrupts); most 
don't care either way. In any case, the core code should deal with it 
based on quirks. I think there isn't any manufacturer who has had both 
kinds of quirk, and the clarified spec says that the INTX bit shouldn't 
matter when MSI is enabled, so manufacturers are slowly converging to 
that.

Initially, the core didn't do anything, and some drivers implemented the 
need-intx-off quirk; eventually this went into the core as the default 
behavior. Then some drivers implemented the need-intx-on quirk. Then some 
common drivers for different hardware turned out to need it both ways, and 
the core got a real quirk for it. But not all of the drivers have dropped 
the local setting stuff.

The right way to go is to do nothing in the driver and use quirks if you 
need it.

	-Daniel
*This .sig left intentionally blank*

  parent reply	other threads:[~2009-01-20 21:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 16:03 Mark Lord
2009-01-20 16:07 ` Mark Lord
2009-01-20 17:44 ` Grant Grundler
2009-01-20 18:16   ` Mark Lord
2009-01-20 18:51     ` Grant Grundler
2009-01-20 19:54       ` Mark Lord
2009-01-21 11:59         ` Tejun Heo
2009-01-20 21:50 ` Daniel Barkalow [this message]
2009-01-21  3:39   ` Mark Lord
2009-01-21  4:02     ` Grant Grundler
2009-01-21  4:16       ` Michael Ellerman
2009-01-21 15:05         ` Mark Lord
2009-01-22  0:33           ` Robert Hancock
2009-01-23 18:11             ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.1.00.0901201626090.19665@iabervon.org \
    --to=barkalow@iabervon.org \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®