From: Jiri Kosina <jkosina@suse.cz>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, llipavsky@suse.cz
Subject: Re: [PATCH] module: make symbol_put_addr() work for all exported symbols
Date: Wed, 25 Jun 2008 10:37:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.1.10.0806251034330.4593@jikos.suse.cz> (raw)
In-Reply-To: <200806231348.58317.rusty@rustcorp.com.au>
On Mon, 23 Jun 2008, Rusty Russell wrote:
> It might be better to centralize all these iterators, and create a
> proper iterator function. Any chance you could rewrite it on top of
> this patch? (Lightly tested)
Hi Rusty,
yes, this looks like better approach. I will respin that patch.
> +struct find_symbol_arg
> +{
> + /* Input */
> + const char *name;
> + bool gplok;
> + bool warn;
> +
> + /* Output */
> + struct module *owner;
> + const unsigned long *crc;
> + unsigned long value;
> +};
I see two options how to do this -- either I can make 'value' input
parameter too, so that find_symbol_in_section() could perform lookup
either according to address or according to name (whatever is specified in
the passed struct find_symbol_arg), or I can do a completely new lookup
function for address-wise lookups. What would you prefer? I don't have any
strong preference either way.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2008-06-25 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 13:11 Jiri Kosina
2008-06-23 3:48 ` Rusty Russell
2008-06-25 8:37 ` Jiri Kosina [this message]
2008-06-25 15:37 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.10.0806251034330.4593@jikos.suse.cz \
--to=jkosina@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llipavsky@suse.cz \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®