From: Jiri Kosina <jkosina@suse.cz>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-input@vger.kernel.org, anssi.hannula@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5 #2] HID: move pantherlord FF processing
Date: Thu, 18 Sep 2008 19:29:10 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.1.10.0809181925050.4671@pegasus.suse.cz> (raw)
In-Reply-To: <1221733414-26924-1-git-send-email-jirislaby@gmail.com>
On Thu, 18 Sep 2008, Jiri Slaby wrote:
> +config HID_PANTHERLORD
> + tristate "Pantherlord"
> + default m
> + depends on USB_HID
> + ---help---
> + Support for PantherLord/GreenAsia based device support (including
> + force feedback).
This comment is a little bit misleading -- it says that
CONFIG_HID_PANTHERLORD includes force feedback support, but you have to
turn that on explicitly by:
> +config PANTHERLORD_FF
> + bool "Force feedback support"
Also, mentioning "Pantherlord" here might make things more clear, this way
it looks like this enables generic force feedback.
I will fix that up in the patchset, if you don't mind, and apply.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2008-09-18 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 10:23 Jiri Slaby
2008-09-18 10:23 ` [PATCH 2/5 #2] HID: move thrustmaster " Jiri Slaby
2008-09-18 10:23 ` [PATCH 3/5 #2] HID: move zeroplus " Jiri Slaby
2008-09-18 10:23 ` [PATCH 4/5 #2] HID: remove hid-ff Jiri Slaby
2008-09-18 10:23 ` [PATCH 5/5 #2] HID: convert to dev_* prints Jiri Slaby
2008-09-18 17:29 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.1.10.0809181925050.4671@pegasus.suse.cz \
--to=jkosina@suse.cz \
--cc=anssi.hannula@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®