mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Bill Gribble <grib@billgribble.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: usbhid:  Changes since 2.6.28 in quirk handling?
Date: Wed, 18 Mar 2009 15:14:29 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.0903181511010.12145@wotan.suse.de> (raw)
In-Reply-To: <1236947942.9606.26.camel@localhost>

On Fri, 13 Mar 2009, Bill Gribble wrote:

> Hi, I have been maintaining a patch for a quirky USB device built-in to 
> a UMPC, the Raon Digital Everun.  Without the patch, the builtin 
> keyboard, mouse, and touchscreen are useless.  I have never submitted it 
> for inclusion in the kernel because there are less than 5 people who 
> have ever even attempted to install Linux on this device, and it's 
> discontinued.  However, *I* use the thing daily, and its wifi device 
> (libertas) has continued to get better support in the recent kernels so 
> I port the patch forward.

Hi Bill,

we have drivers (and even whole architectures) supported by the kernel, 
which have less than 5 users in the world, that's not a big deal.

It makes 5 people happy, and saves you the pain from having to keep the 
out-of-tree code working with the Linux kernel API changing all the time.

> I noticed that the structure of the quirk handling code has changed 
> somewhat; I left my patch using the "old" way of adding an entry to 
> hid_blacklist in hid-quirks.c.  Is there a document or email trail that 
> describes the new way of structuring this quirk code?  Any pitfalls to 
> look out for?

Looking at your patch, the only thing you need is sending a special URB to 
the device in order to make it operational, right?

Please look at hid-sony driver, which does exactly that for some of the 
PS3 devices.

You then only need to add your device to hid_blacklist[], so that generic 
driver doesn't get bound to it and it'd be driven by your special driver.

-- 
Jiri Kosina
SUSE Labs

  reply	other threads:[~2009-03-18 14:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13 12:39 Bill Gribble
2009-03-18 14:14 ` Jiri Kosina [this message]
2009-03-18 14:29   ` Bill Gribble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.0903181511010.12145@wotan.suse.de \
    --to=jkosina@suse.cz \
    --cc=grib@billgribble.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®