From: Jiri Kosina <jkosina@suse.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: hid tree build failure
Date: Fri, 26 Jun 2009 10:53:24 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.0906261052350.18021@wotan.suse.de> (raw)
In-Reply-To: <20090626153100.de647d08.sfr@canb.auug.org.au>
On Fri, 26 Jun 2009, Stephen Rothwell wrote:
> Today's linux-next build (sparc32 defconfig) failed like this:
>
> drivers/hid/hid-core.c:862:34: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
> drivers/hid/hid-core.c: In function 'hid_process_event':
> drivers/hid/hid-core.c:862: error: 'hid_dump_input' undeclared (first use in this function)
> drivers/hid/hid-core.c:862: error: (Each undeclared identifier is reported only once
> drivers/hid/hid-core.c:862: error: for each function it appears in.)
> drivers/hid/hid-core.c:984:68: error: macro "hid_dump_input" passed 3 arguments, but takes just 2
> drivers/hid/hid-core.c: In function 'hid_set_field':
> drivers/hid/hid-core.c:984: error: 'hid_dump_input' undeclared (first use in this function)
> drivers/hid/hid-core.c: In function 'hid_input_report':
> drivers/hid/hid-core.c:1090: error: 'HID_DEBUG_BUFSIZE' undeclared (first use in this function)
>
> Caused by commit cd667ce24796700e1a0e6e7528efc61c96ff832e ("HID: use
> debugfs for events/reports dumping") which modified the prototype for
> hid_dump_input, but not the !CONFIG_DEBUG_FS version. It also added
> HID_DEBUG_BUFSIZE when CONFIG_DEBUG_FS, but used it otherwise.
>
> I have reverted that commit for today (along with commit
> a635f9dd83f3382577f4544a96df12356e951a40 ("HID: use debugfs for report
> dumping descriptor") which doesn't build without the other one).
Hi Stephen,
should be now fixed in the branch you pull into -next.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2009-06-26 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 5:31 Stephen Rothwell
2009-06-26 8:53 ` Jiri Kosina [this message]
2009-06-26 17:28 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.0906261052350.18021@wotan.suse.de \
--to=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®