mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Barkalow <barkalow@iabervon.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: apw@canonical.com, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch whitespace
Date: Tue, 21 Jul 2009 11:48:37 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LNX.2.00.0907211139400.2147@iabervon.org> (raw)
In-Reply-To: <20090721100113.GC4133@elf.ucw.cz>

On Tue, 21 Jul 2009, Pavel Machek wrote:

> I don't think that a bit of trailing whitespace hurts that much (it is
> very easy to create when fixing overly long lines, another checkpatch
> complain), and at least akpm autofixes the whitespace, anyway, but...

The problem with trailing whitespace in files is that future developers 
have to keep it the same while making changes in the area, or it'll add 
noise to their commits and patches. Fixing up a patch to stop removing 
trailing whitespace is even more of a pain than fixing a patch to stop 
adding it.

> Would it be possible to add autofixing to checkpatch? Fixing
> whitespace issues by hand is useless & boring task...

Until checkpatch does it, "git apply" can be configured to auto-correct.

	-Daniel
*This .sig left intentionally blank*

  reply	other threads:[~2009-07-21 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 10:01 Pavel Machek
2009-07-21 15:48 ` Daniel Barkalow [this message]
2009-07-22 11:05 ` Bartlomiej Zolnierkiewicz
2009-07-21 13:06   ` Andy Whitcroft
2009-07-21 22:37     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.0907211139400.2147@iabervon.org \
    --to=barkalow@iabervon.org \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®