From: Jiri Kosina <jkosina@suse.cz>
To: Wayne Thomas <waynethomas69@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: HID: expand hid-topseed driver to support BTC "Emprex 3009URF III Vista MCE Remote"
Date: Wed, 28 Apr 2010 13:51:22 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1004281349130.9849@pobox.suse.cz> (raw)
In-Reply-To: <y2u3711715e1004272206u4700fac7u744b2fb0cf203367@mail.gmail.com>
On Wed, 28 Apr 2010, Wayne Thomas wrote:
> >> OK, next attempt...
> >
> > The patch is OK, but your mail client whitespace-damaged it. Could you
> > please fix up your client and resend? (or attach it separately as an
> > attachment, if your client can't be fixed).
> >
> > Thanks,
>
> I thought it might have; sorry about that.
> Have attached patch as separate file as a precaution.
Thanks for the patch.
What is the reason for it being backwards-compatible with the older
topspeed device?
Changes such as
- case 0x048: ts_map_key_clear(KEY_RED); break;
+ case 0x05b: ts_map_key_clear(KEY_RED); break;
(and no other handling of neither 0x048 nor KEY_RED) make me wonder ...
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2010-04-28 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 14:18 Wayne Thomas
2010-04-26 9:48 ` Jiri Kosina
2010-04-27 18:45 ` Wayne Thomas
2010-04-27 20:43 ` Jiri Kosina
2010-04-28 5:06 ` Wayne Thomas
2010-04-28 11:51 ` Jiri Kosina [this message]
2010-04-28 14:54 ` Wayne Thomas
2010-04-28 22:46 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1004281349130.9849@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=waynethomas69@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®