From: Jesper Juhl <jj@chaosbits.net>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, Alexey Dobriyan <adobriyan@gmail.com>,
Dan Carpenter <error27@gmail.com>,
Shmulik Ravid <shmulikr@broadcom.com>,
John Fastabend <john.r.fastabend@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Lucy Liu <lucy.liu@intel.com>
Subject: [PATCH] Don't potentially dereference NULL in net/dcb/dcbnl.c:dcbnl_getapp()
Date: Thu, 10 Feb 2011 22:57:16 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1102102253230.8012@swampdragon.chaosbits.net> (raw)
nla_nest_start() may return NULL. If it does then we'll blow up in
nla_nest_end() when we dereference the pointer.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
dcbnl.c | 3 +++
1 file changed, 3 insertions(+)
only compile tested.
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 6b03f56..13cdc30 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -626,6 +626,9 @@ static int dcbnl_getapp(struct net_device *netdev, struct nlattr **tb,
dcb->cmd = DCB_CMD_GAPP;
app_nest = nla_nest_start(dcbnl_skb, DCB_ATTR_APP);
+ if (!app_nest)
+ goto out_cancel;
+
ret = nla_put_u8(dcbnl_skb, DCB_APP_ATTR_IDTYPE, idtype);
if (ret)
goto out_cancel;
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Plain text mails only, please.
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
next reply other threads:[~2011-02-10 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 21:57 Jesper Juhl [this message]
2011-02-13 19:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1102102253230.8012@swampdragon.chaosbits.net \
--to=jj@chaosbits.net \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucy.liu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shmulikr@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®