From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962Ab1CETPx (ORCPT ); Sat, 5 Mar 2011 14:15:53 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:12127 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753289Ab1CETPw (ORCPT ); Sat, 5 Mar 2011 14:15:52 -0500 Date: Sat, 5 Mar 2011 20:15:18 +0100 (CET) From: Jesper Juhl To: Cesar Eduardo Barros cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , KAMEZAWA Hiroyuki , Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, Eric B Munson Subject: Re: [PATCHv2 08/24] sys_swapon: move setting of error nearer use In-Reply-To: <1299343345-3984-9-git-send-email-cesarb@cesarb.net> Message-ID: References: <1299343345-3984-1-git-send-email-cesarb@cesarb.net> <1299343345-3984-9-git-send-email-cesarb@cesarb.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 5 Mar 2011, Cesar Eduardo Barros wrote: > Move the setting of the error variable nearer the goto in a few places. > > Avoids calling PTR_ERR() if not IS_ERR() in two places, and makes the > error condition more explicit in two other places. > > Signed-off-by: Cesar Eduardo Barros > Tested-by: Eric B Munson > Acked-by: Eric B Munson Looks good to me. Reviewed-by: Jesper Juhl -- Jesper Juhl http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html