From: Jiri Kosina <jkosina@suse.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: Re: linux-next: manual merge of the trivial tree with the ux500-core tree
Date: Fri, 6 May 2011 11:44:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1105061144200.28291@pobox.suse.cz> (raw)
In-Reply-To: <BANLkTimHgUorm4HKuX7veUNR6M1o9LiTNA@mail.gmail.com>
On Fri, 6 May 2011, Linus Walleij wrote:
> 2011/5/5 Jiri Kosina <jkosina@suse.cz>:
> > On Fri, 29 Apr 2011, Linus Walleij wrote:
> >>
> >> I rewrote the driver completely so likely it will rather be dropped, but
> >> please check! I'll be happy to carry any patches.
> >
> > Seems to me that all the calls to request_mem_region() and
> > release_mem_region() still need the resource_size() fixup even in the new
> > driver.
>
> OK I went in and tweaked the patch like this:
>
> if (request_mem_region(gpio->memres->start,
> resource_size(gpio->memres),
> "GPIO Controller")
> == NULL) {
> dev_err(gpio->dev, "could not reserve GPIO memory region\n");
> err = -ENODEV;
> goto err_no_ioregion;
> }
> (...)
> err_no_ioremap:
> release_mem_region(gpio->memres->start, resource_size(gpio->memres));
> (...)
> release_mem_region(gpio->memres->start,
> resource_size(gpio->memres));
>
> It'll appear in the next tree tomorrow or so. OK?
Thanks. I have dropped Joe's patch from my queue now.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2011-05-06 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 1:59 Stephen Rothwell
2011-04-29 7:25 ` Linus Walleij
2011-05-05 13:48 ` Jiri Kosina
2011-05-06 9:29 ` Linus Walleij
2011-05-06 9:44 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1105061144200.28291@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®