From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756673Ab1E2UCJ (ORCPT ); Sun, 29 May 2011 16:02:09 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:35895 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786Ab1E2UCH (ORCPT ); Sun, 29 May 2011 16:02:07 -0400 Date: Sun, 29 May 2011 21:54:18 +0200 (CEST) From: Jesper Juhl To: Andy Lutomirski cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] x86-64: Replace vsyscall gettimeofday fallback with int 0xcc In-Reply-To: Message-ID: References: <452208dbdf79d4c821d701d5973621bf7546419a.1306517576.git.luto@mit.edu> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 May 2011, Jesper Juhl wrote: > On Fri, 27 May 2011, Andy Lutomirski wrote: > > > Now the only way to issue a syscall with side effects through the > > vsyscall page is to call a misaligned instruction. I haven't > > checked for that. > > > > Signed-off-by: Andy Lutomirski > > --- > > arch/x86/include/asm/traps.h | 4 +++ > > arch/x86/include/asm/vsyscall.h | 6 +++++ > > arch/x86/kernel/entry_64.S | 2 + > > arch/x86/kernel/traps.c | 4 +++ > > arch/x86/kernel/vsyscall_64.c | 47 ++++++++++++++++++++++++++++++++++----- > > 5 files changed, 57 insertions(+), 6 deletions(-) > > > > one very tiny nit below. > > [...] > > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c > > index b9b6716..d34894e 100644 > > --- a/arch/x86/kernel/traps.c > > +++ b/arch/x86/kernel/traps.c > > @@ -872,6 +872,10 @@ void __init trap_init(void) > > set_bit(SYSCALL_VECTOR, used_vectors); > > #endif > > > > + set_system_intr_gate(0xCC, &intcc); > > + set_bit(0xCC, used_vectors); > > + printk(KERN_ERR "intcc gate isntalled\n"); > > Let's spell the error message correctly: > > printk(KERN_ERR "intcc gate installed\n"); > Hmm, why is this KERN_ERR btw? Shouldn't it just be KERN_NOTICE or KERN_INFO ? -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.