From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756789Ab1GJW5B (ORCPT ); Sun, 10 Jul 2011 18:57:01 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:20148 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756748Ab1GJW47 (ORCPT ); Sun, 10 Jul 2011 18:56:59 -0400 Date: Mon, 11 Jul 2011 00:56:57 +0200 (CEST) From: Jesper Juhl To: Randy Dunlap cc: Arnaud Lacombe , Pekka Enberg , =?ISO-8859-15?Q?Am=E9rico_Wang?= , Raghavendra D Prabhu , linux-kbuild@vger.kernel.org, Nir Tzachar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Avoid Wunused-but-set warning In-Reply-To: <20110710110241.7650e03f.rdunlap@xenotime.net> Message-ID: References: <20110710110241.7650e03f.rdunlap@xenotime.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1188144095-1310338618=:2818" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1188144095-1310338618=:2818 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT On Sun, 10 Jul 2011, Randy Dunlap wrote: > On Sun, 10 Jul 2011 12:49:20 -0400 Arnaud Lacombe wrote: > > > Hi, > > > > On Sun, Jul 10, 2011 at 12:28 PM, Pekka Enberg wrote: > > > On Sun, Jul 10, 2011 at 7:24 PM, Arnaud Lacombe wrote: > > >> Hi, > > >> > > >> On Sun, Jul 10, 2011 at 12:16 PM, Américo Wang wrote: > > >>> On Sun, Jul 10, 2011 at 12:24 AM, Raghavendra D Prabhu > > >>> wrote: > > >>>> Hi, > > >>>>    I am seeing Wunused-but-set warning while make nconfig.  Looks like > > >>>>    active_menu is not used. Removing it fixes the warning. > > >>>> > > >>>> Signed-off-by: Raghavendra D Prabhu > > >>> > > >>> Acked-by: WANG Cong > > >>> > > >> Out of curiosity, what is your status to ACK such patch ? > > > > > > What kind of status do you need to ACK such a simple patch? > > > > > As per Documentation/SubmittingPatches: > > > > << > > 13) When to use Acked-by: and Cc: > > The Signed-off-by: tag indicates that the signer was involved in the > > development of the patch, or that he/she was in the patch's delivery path. > > > > If a person was not directly involved in the preparation or handling of a > > patch but wishes to signify and record their approval of it then they can > > arrange to have an Acked-by: line added to the patch's changelog. > > > > Acked-by: is often used by the maintainer of the affected code when that > > maintainer neither contributed to nor forwarded the patch. > > >> > > > > That said, it is not a strong requirement... unfortunately. So, let's > > have some fun and go ACK thousand of trivial patch just to generate > > traffic on the LKML and give myself self-importance :-) > > Acked-by: is mostly used as a weak version of Reviewed-by: > and the "definition" in SubmittingPatches is not accurate IMO. > I.e., it can be used by anyone. > Interesting. I was under the impression that Reviewed-by: was a weaker thing than Acked-by: - I certainly have been using it as such. I've always interpreted Acked-by: as being something you could apply if you were the author, maintainer or other person with similar strong background knowledge of the code. Where Reviewed-by: could be used by anyone, as long as they had taken the time to read the patch and try and understand what was going on and the result/conclusion looked good. -- Jesper Juhl http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. --8323328-1188144095-1310338618=:2818--