From: Jiri Kosina <jkosina@suse.cz>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>,
Sergei Kolzun <x0r@dv-life.ru>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: ACRUX - add missing hid_hw_stop() in ax_probe() error path
Date: Thu, 14 Jul 2011 11:43:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1107141143230.7300@pobox.suse.cz> (raw)
In-Reply-To: <1310620071.2721.3.camel@phoenix>
On Thu, 14 Jul 2011, Axel Lin wrote:
> hid_hw_stop() must be called in ax_probe() error path if hid_hw_start()
> was successful.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/hid/hid-axff.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-axff.c b/drivers/hid/hid-axff.c
> index b455428..1215141 100644
> --- a/drivers/hid/hid-axff.c
> +++ b/drivers/hid/hid-axff.c
> @@ -154,6 +154,7 @@ static int ax_probe(struct hid_device *hdev, const struct hid_device_id *id)
> error = hid_hw_open(hdev);
> if (error) {
> dev_err(&hdev->dev, "hw open failed\n");
> + hid_hw_stop(hdev);
> return error;
> }
Good catch, applied. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2011-07-14 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 5:07 Axel Lin
2011-07-14 9:43 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1107141143230.7300@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=axel.lin@gmail.com \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x0r@dv-life.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®