From: Kai Makisara <Kai.Makisara@kolumbus.fi>
To: Lee Duncan <lduncan@suse.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SCSI, st: modify tape driver to allow writing immediate filemarks
Date: Wed, 8 Feb 2012 19:19:06 +0200 (EET) [thread overview]
Message-ID: <alpine.LNX.2.00.1202081910400.6087@kai.makisara.local> (raw)
In-Reply-To: <4F31CAC0.3010905@suse.com>
On Tue, 7 Feb 2012, Lee Duncan wrote:
> Add an st module option st_nowait_eof which defaults to 0. Setting this
> option to 1 tells the st driver not to wait when writing a filemark, which
> can result in much faster times on streaming tape drives.
>
> Legacy applications cannot take advantage of the newer MTWEOFI ioctl, so this
> patch gives such applications the ability to write an immediate EOF using the
> normal MTWEOF ioctl if they set st_nowait_eof=1.
>
> Reference: https://bugzilla.novell.com/show_bug.cgi?id=688996
>
Is there a real application? I can't open your reference. (Yes, I know
that this feature can speed up writing dramatically in some cases, but is
there a case with legacy applications?)
Anyway, I don't think this should be implemented as a pure module option.
The standard semantics specify that MTWEOF is a synchronization point and
this module option breaks that for all users.
The driver supports several tape device files with different properties
that can be set at run-time. Why not implement this as one of the mode
options? This would allow the "normal" users to use a device file with
synchronizing MTWEOF and the users needing unsynchronizing MTWEOF would
use another device file.
The st driver exports the options in sysfs. This is important so that the
users can check what the options for a device are. This new option should
also be exported.
Kai
next prev parent reply other threads:[~2012-02-08 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 1:07 Lee Duncan
2012-02-08 1:15 ` Joe Perches
2012-02-09 17:22 ` Lee Duncan
2012-02-08 17:19 ` Kai Makisara [this message]
2012-02-09 17:43 ` Lee Duncan
2012-02-28 19:38 ` Kai Makisara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1202081910400.6087@kai.makisara.local \
--to=kai.makisara@kolumbus.fi \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®